fix(design): Remove autoprefixer comment for webpack v5 #2132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying atlantis with
|
| Latest commit: |
7584b73
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://903be518.atlantis.pages.dev |
| Branch Preview URL: | https://cleanup-autoprefixer-warning.atlantis.pages.dev |
jdeichert
reviewed
Nov 19, 2024
| @@ -7,7 +7,6 @@ | |||
| } | |||
|
|
|||
| /* Safari doesn't support scrollbar-color yet, so we're using the non-standard selector for now. */ | |||
| /* autoprefixer: off */ | |||
There was a problem hiding this comment.
Hey @timkooi-jobber, thanks for looking into this!
I just tested this locally and found that removing both comments seems to work fine. I realized we used to need this comment due to us checking @supports with ::-webkit-scrollbar which is why our (atlantis) postcss was erroring before... but that's no longer the case as of 2 weeks ago.
Once you remove the second comment, we can build a pre-release of the design package for you to test in JO with your webpacker upgrade, to confirm it's working.
jdeichert
changed the title
|
Published Pre-release for 7584b73 with versions: To install the new version(s) for Web run: To install the new version(s) for Mobile run: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivations
Upgrading to Webpack v5, we were getting a warning that the second autoprefixer comment was being ignored. This would cause an overlay of the warning on the Jobber application.
Changes