Fix for Hebrew translation (he_IL) #54
Conversation
sprintf expects placeholders to use the format `%1$s`. Prior to v8, placeholders with a space would be interpreted incorrectly, but would not throw an error. In v8 PHP throws a fatal error, causing all the Gibbons to escape. Live example: https://onlinephp.io/c/523c3 This commit removes the extraneous spacing on 361 placeholders.
The 21 placeholders fixed were missing the "s" identifying the replacement type.
Less obvious issues, such as placeholders that span multiple lines or that were missing the `%`
|
Hi Sam, thank you for your work to fix these translation issues. As you've noted, there were errors in the string replacement formats, which previous to PHP 8 would have been ignored, but now generate a fatal error. We use the online tool PoEditor, so I've downloaded and merged your .po file into the online translations, then generated new .mo and .po files from PoEditor, which have now been pushed to this repository. Can you please download and test these new files and let me know if they have solved the issue: 4bba3d7 |
|
Fantastic!
I downloaded and tested with the .mo file from git, and it works as
expected.
In the interim, I have made a whole bunch of other changes.
I "import"ed and added translations on poedit for many of the items that
were missing, but I don't know how to save them.
I also would change the translations for many of the phrases (you can see
in my git repo a few more pushes, but I can update poeditor directly), but
I do not know what is expected of me as far as keeping records of
changes, as far as publishing files, etc.
Sam.
…On Mon, Dec 2, 2024 at 3:23 AM Sandra Kuipers ***@***.***> wrote:
Hi Sam, thank you for your work to fix these translation issues. As you've
noted, there were errors in the string replacement formats, which previous
to PHP 8 would have been ignored, but now generate a fatal error. We use
the online tool PoEditor, so I've downloaded and merged your .po file into
the online translations, then generated new .mo and .po files from
PoEditor, which have now been pushed to this repository. Can you please
download and test these new files and let me know if they have solved the
issue: 4bba3d7
<4bba3d7>
—
Reply to this email directly, view it on GitHub
<#54 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAALPPKPG5HPFDFUPIJQ4G32DOY77AVCNFSM6AAAAABSS2RNOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMJQGM3TIMJUGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Hi Sam, thanks for these updates and your continued translations! Yes, adding them to PoEditor would be best. Generally, I publish the translations from PoEditor every release, which pushes them to GitHub. However, feel free to let me know when you've completed some of your changes and I'm always happy to publish them mid-release. Thanks! |
Gibbon has been broken entirely when using the Hebrew translation, since upgrading to Php v8 (all pages show an error that the Gibbons have escaped).
The issue has to do with the way Php changed the handling of replacement strings.
This fork fixes the issues, and is tested with both Gibbon v24 and Gibbon v28.
The changes were all made in `22 (for Gibbon-24). Have now rebased the changes onto main, and tested with Gibbon-28, so that others can benefit as well.