Merge pull request #101 from Giphy/feat/PG-1261

chore(e2e): fix GIPHY Dialog selectors
Giphy · Apr 27, 2023 · bcda248 · bcda248
2 parents 82b289f + 491a526
commit bcda248
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/android/build.gradle b/android/build.gradle
@@ -167,6 +167,6 @@ preBuild.dependsOn configureGiphyVideoPlayerAdapter
 dependencies {
   // noinspection GradleDynamicVersion
   api 'com.facebook.react:react-native:+'
-  implementation 'com.giphy.sdk:ui:2.3.1'
+  implementation 'com.giphy.sdk:ui:2.3.4'
   implementation 'org.jetbrains.kotlin:kotlin-reflect:1.5.31'
 }
diff --git a/e2e/GiphyDialogSettings.e2e.ts b/e2e/GiphyDialogSettings.e2e.ts
@@ -66,7 +66,11 @@ function getGPHDialogTouchInterceptor() {
   if (device.getPlatform() === 'ios') {
     return element(by.type('UICollectionView').withDescendant(by.type('GiphyUISDK.GPHMediaCell')))
   }
-  return element(by.type('com.giphy.sdk.ui.views.GPHTouchInterceptor'))
+  return element(
+    by
+      .type('com.giphy.sdk.ui.views.GPHTouchInterceptor')
+      .withAncestor(by.type('com.giphy.sdk.ui.views.dialogview.GiphyDialogView'))
+  )
 }
 
 function getGPHDialogMediaCell() {

diff --git a/example/ios/Podfile.lock b/example/ios/Podfile.lock
@@ -439,4 +439,4 @@ SPEC CHECKSUMS:
 
 PODFILE CHECKSUM: 113b401ed56c27385e4e1f7e90d7bb9e356e084a
 
-COCOAPODS: 1.12.0
+COCOAPODS: 1.12.1
Original file line number	Diff line number	Diff line change
Expand Up		@@ -439,4 +439,4 @@ SPEC CHECKSUMS:

		PODFILE CHECKSUM: 113b401ed56c27385e4e1f7e90d7bb9e356e084a

		COCOAPODS: 1.12.0
		COCOAPODS: 1.12.1