Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android Only]GiphyGridView content changes from GiphyContent.trendingGifs to GiphyContent.recents, GiphyGridView not refresh. #126

Closed
THDGunner opened this issue Jul 14, 2023 · 4 comments · Fixed by #128
Labels
bug Something isn't working

Comments

@THDGunner
Copy link

  • Giphy React Native SDK version: 2.4.1
  • React Native version: 0.69.7
  • Platform(s) (iOS, Android, or both?): Android
  • Device info (Simulator/Device? OS version? Debug/Release?): Android Devices
@THDGunner THDGunner added the bug Something isn't working label Jul 14, 2023
@pshoniuk
Copy link
Contributor

Hi @THDGunner
Thank you for the report. We'll release a fix in the next version. I'll update the status here when that happens

@pshoniuk
Copy link
Contributor

Hi @THDGunner
We released a fix in v2.4.2

@THDGunner
Copy link
Author

THDGunner commented Jul 19, 2023

Hi @THDGunner We released a fix in v2.4.2

Hi @pshoniuk , Thank you for the quick reply!
Unfortunately this issue is not resolved yet.I upgraded to the latest(v2.4.2) version and tested it on an android device(Google pixel6).The phenomenon is the same as before.

@pshoniuk
Copy link
Contributor

@THDGunner I couldn't reproduce the issue in v2.4.2. It might be a problem with the gradle cache. Please ensure your project uses the correct version of the GIPHY UI SDK, which should be: com.giphy.sdk:ui:2.3.6-hotfix-grid. To check this, you can inspect the output of this command running from the android folder:
./gradlew app:dependencies | grep 'com.giphy.sdk:ui'
If the version is correct, it would be great if you could share more details or, ideally, a minimal playground where the issue occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants