-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stack overflow exception in 3.6.5 #1328
Comments
Please upgrade to v4 beta. It has changed a lot in this area and might have fixed the issue. |
FYI, we are now receiving stack overflow errors via the GitVersion TFS/VSTS build task. But, if I use it locally from the Chocolatey package (which still has 3.6.4), it works fine and quickly. When it fails on TFS (2018 Update 2), it is generating a large log file and ends with a stack overflow error. If you need the full log, I can attach, but I'll have to scrub it first. Here's the snippet from the actual exception:
I verified the version that TFS is using through the task and it's 3.6.5. This obviously is not something we can update to v4 beta. |
@asbjornu given that this is now breaking some of our critical builds, is there a workaround when used with TFS? I checked the log and there's no way I'm scrubbing it. It's 84 MB. It seems now when it is trying to get a version from a feature branch, its process of trying to figure out what the actual version is keeps falling back so many times that it just runs out of memory, I'm guessing. |
@sumo300, I don't have a solution to this other than somehow upgrading to v4. I will work to get a stable v4 out the door if that's of any help. From which source do you consume/install GitVersion as upgrading to v4 is not an option? |
@asbjornu It's whatever is included in the GitVersion TFS/VSTS extension. We don't install GitVersion on its own and I don't think it would be used if we did on the build servers, specifically this one: https://marketplace.visualstudio.com/items?itemName=gittools.gitversion#overview |
@asbjornu Interesting detail. We abandoned the pull request where the build was failing due to GitVersion. Created a new PR and it worked fine. So, we're not blocked any more. We will be looking for the 4.0 version. :) |
@asbjornu Just note that abandoning the PR and re-submitting only works every once in a while. This issue is occurring pretty frequently. If there was a way to get the GitVersion TFS extension that used the beta version, we'd certainly try it. |
Looks like this issue #1518 is related to this problem as well.
|
|
I Still see the same issue in GitVersion 4.0.3 (when it is merging from MAster to Develop). I feel, the issue is related to PR commits. Any update on this? I have created a separate bug for the same without know here it is;(. |
Are any of the repositories this problem is occurring in available publicly? |
I don't have a public repository. But I can share you complete logs if you need. Please let me know the location where you want to copy. |
Hi asbjornu, We have completely blocked with this issue. We have tried with back merging Develop to a feature branch and merging Master to the same feature branch. Again, it is failing with same issue. Any help would be greatly appreciated. Thanks, |
I don't suppose logs will help much in debugging this issue. We would need to set a breakpoint, run the code and see where it breaks and what state the application is in at that moment. If you can do that with the source code of GitVersion on your private failing repository, it would be very valuable to us. |
This issue has been automatically marked as stale because it has not had recent activity. After 30 days from now, it will be closed if no further activity occurs. Thank you for your contributions. |
This happens on our TFS Build system.
I've attached the log.
4_GitVersion.zip
I think what's happening is the fallback search for the master branch is returning feature/ExProSlowness_MergeForMaster before master
What would you suggest as the best workaround please?
The text was updated successfully, but these errors were encountered: