Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack overflow due to infinite loop falling back to branch config #1518

Closed
sumo300 opened this issue Oct 26, 2018 · 10 comments
Closed

Stack overflow due to infinite loop falling back to branch config #1518

sumo300 opened this issue Oct 26, 2018 · 10 comments
Labels
Milestone

Comments

@sumo300
Copy link

sumo300 commented Oct 26, 2018

In a repository that only has a master and a release branch, during a pull request build (TFS 2018 Update 2), GitVersion goes into an infinite loop and eventually errors out with a stackoverflow error.

This happens with both 3.6.5 and the latest 4.0.0 version (4.0.1 version of the VSTS task and using the latest version of GitVersion from Chocolatey).

I have attached the GitVersion.yml file and the logs from our latest failing build. This yml config fixes the issue by forcing pull requests to use Patch rather than Inherit for the increment setting. When it defaults to Inherit, it cannot figure out the fallback version.

GitVersion-log.zip
GitVersion.yml.zip

@sumo300
Copy link
Author

sumo300 commented Nov 9, 2018

This is now failing on a build with the 4.0 version of GitVersion on a tagged build. This should not happen if I'm interpreting the docs correctly.

@sumo300
Copy link
Author

sumo300 commented Nov 9, 2018

Another update. On the repo we had issues, we did a massive branch clean-up, and this seems to have helped for now.

@sumo300
Copy link
Author

sumo300 commented Nov 28, 2018

This problem will just not go away. Any chance at all there is a potential fix for this issue?

@PavelDanov
Copy link

I've also encountered this issue recently. Will GitVersion support Microsoft's Release Flow as a first-class citizen eventually?

@stale
Copy link

stale bot commented Aug 1, 2019

This issue has been automatically marked as stale because it has not had recent activity. After 30 days from now, it will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 1, 2019
@stale stale bot closed this as completed Aug 31, 2019
@thepirat000
Copy link

So you will never fix this

@Huffers
Copy link

Huffers commented Jul 30, 2020

This happened to me on a merge commit.
I was able to workaround the issue by switching the parents of the merge commit, using this stack overflow answer.

@asbjornu
Copy link
Member

@thepirat000, there is no "you", it's "we". No one is getting paid to work on GitVersion, so unless someone submits a pull request to fix this issue, it's not going to get fixed. So far we haven't gotten a single reproduction, not a public repository where the problem exists, not a TestFixture, nothing. Until we do, this bug will persist.

@asbjornu asbjornu reopened this Jul 31, 2020
@stale stale bot removed the stale label Jul 31, 2020
@asbjornu asbjornu added the bug label Jul 31, 2020
@HHobeck
Copy link
Contributor

HHobeck commented Mar 2, 2023

Hi there. I'm going to close this issue because no one is providing steps to reproduce. In advance the whole mechanism to determine the branch configuration has been changed. Thus this should not happened in version 6.x anymore. Please reopen this issue or create a new bug if the stack overflow issue still persists.

Cheers.

@HHobeck HHobeck closed this as completed Mar 2, 2023
@HHobeck HHobeck added this to the 6.x milestone Mar 2, 2023
@arturcic arturcic modified the milestones: 6.x, 6.0.0-beta.1 Mar 2, 2023
@arturcic
Copy link
Member

arturcic commented Mar 2, 2023

🎉 This issue has been resolved in version 6.0.0-beta.1 🎉
The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants