Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitVersionTask missing output, GitVersion_EscapedBranchName #2398

Closed
owns opened this issue Sep 3, 2020 · 2 comments · Fixed by #2399
Closed

GitVersionTask missing output, GitVersion_EscapedBranchName #2398

owns opened this issue Sep 3, 2020 · 2 comments · Fixed by #2399
Milestone

Comments

@owns
Copy link
Contributor

owns commented Sep 3, 2020

I'm always frustrated when I have to do a task to access GitVersion_EscapedBranchName in my project's build.

Detailed Description

After GitVersionTask run, property GitVersion_EscapedBranchName should be created.

Context

Currently, I copy-and-pasted the GetVersion task with only one Output and parameter EscapedBranchName.
This Improvement would reduce "secret" GitVersion knowledge needed in my build process.
I think others may like to use the new property too - it's great!

Possible Implementation

1 line to add to after here copy-and-pasted with BranchName replaced with EscapedBranchName.

@owns
Copy link
Contributor Author

owns commented Sep 3, 2020

created pr #2399 to help get the ball rolling.

@asbjornu asbjornu added this to the 5.5.0 milestone Sep 3, 2020
@arturcic
Copy link
Member

🎉 This issue has been resolved in version 5.5.0 🎉
The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants