Update GitVersionTask.targets #2399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added GitVersion_EscapedBranchName
asbjornu
approved these changes
Sep 3, 2020
|
Thank you for your contributions @owns! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added GitVersion_EscapedBranchName
Description
Output
EscapedBranchNamefrom theGetVersiontask to a new propertyGitVersion_EscapedBranchName.Related Issue
Fixes #2398.
Motivation and Context
New property #2157 added.
It appears the line was just missed in the above pr. The change was made to src/GitVersionTask.MsBuild/Tasks/GetVersion.cs to add the output; exposing the property just wasn't updated in the target.
How Has This Been Tested?
I tested by making the changing on my build machine in the nuget cache (
~\.nuget\packages\gitversiontask\5.3.7\build\GitVersionTask.targets).ReBuilt my project shoulded the new property was created.
Screenshots (if appropriate):
Checklist: