Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Microsoft.NET.Sdk.BlazorWebAssembly not supported #2890

Closed
mentthew-pjwstk opened this issue Oct 26, 2021 · 4 comments · Fixed by #2891
Closed

[Feature] Microsoft.NET.Sdk.BlazorWebAssembly not supported #2890

mentthew-pjwstk opened this issue Oct 26, 2021 · 4 comments · Fixed by #2891
Labels
Milestone

Comments

@mentthew-pjwstk
Copy link

Currently supported project SDKs:

  • "Microsoft.NET.Sdk"
  • "Microsoft.NET.Sdk.Web"
  • "Microsoft.NET.Sdk.WindowsDesktop"
  • "Microsoft.NET.Sdk.Razor"
  • "Microsoft.NET.Sdk.Worker"

I think there should also be added Microsoft.NET.Sdk.BlazorWebAssembly

In file https://github.com/GitTools/GitVersion/blob/e41cc2b69a7723ce43c5f54885973bd5f738eee5/src/GitVersion.Core/VersionConverters/AssemblyInfo/ProjectFileUpdater.cs
we can extend supportedSdks array:
var supportedSdks = new[] { "Microsoft.NET.Sdk", "Microsoft.NET.Sdk.Web", "Microsoft.NET.Sdk.WindowsDesktop", "Microsoft.NET.Sdk.Razor", "Microsoft.NET.Sdk.Worker", "Microsoft.NET.Sdk.BlazorWebAssembly" };

@asbjornu
Copy link
Member

Sure, pull requests welcome.

@arturcic
Copy link
Member

@asbjornu I think a better idea would be not to add a new sdk to the list every time one is requested, but better to check whether the Sdk attribute has the Microsoft.NET.Sdk prefix in the attribute value. What do you think?

@asbjornu
Copy link
Member

That would indeed be an improvement, @arturcic! 👍🏼

@github-actions
Copy link

🎉 This issue has been resolved in version 5.8.0 🎉
The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants