Add assembly-file-versioning-format with support for environment variables

[ruhullahshah]

Fix for issue #1366

Implementation methodology same as suggested by @jbaehr in #1157

[jbaehr]

Thanks a lot for your work. I gave it a try and it works like a charm (just remember to call GitVersion.exe with -nocache when playing around ;-) ).

I would love a comment from the maintainers whether this approach has chances to get merged. @asbjornu, you already gave thumbs up on my comment in #1157... Please tell us if you request further changes to the implementation, format string syntax, or the like.

[ruhullahshah]

@jbaehr You are welcome and thanks for testing out the changes :)

[asbjornu]

I think this looks really promising. I just have a few comments, so please address or debate them before we move forward. Thanks for doing this!

[ruhullahshah]

@asbjornu You are welcome. I have addressed some of your review comments and provided my opinion on others. In my opinion, we have the functionality in place that addresses the theme of this issue.

[asbjornu]

I think this looks good now, minus one question. Thanks!

[ruhullahshah]

You are welcome. I have included the changes for the null propagation operator readability and updated some test cases.

[asbjornu]

Just a few new questions, otherwise this looks good!

[ruhullahshah]

@asbjornu I would like to address all the changes you request in one go. This is getting repetitive. The review before this should have had these comments because these changes have been there before the last commit. I will give you some time to make up your mind about the PR as a whole and once you have reviewed all the code let me know, i will address your comments.

[asbjornu]

@ruhullahshah: Sorry about that. I was sure the latest review was for new code. I should of course have reviewed that in the first go, but if I remember correctly, I had limited time when I did the first review so it wasn't as thorough as I would have liked.

[asbjornu]

Excellent. Thanks for this!

[ruhullahshah]

You are welcome :)

[vishalvatsal]

Hi Team,
@asbjornu , @ruhullahshah
I have a need to use build number in the assembly version for my TeamCity build.

Following is my gitversion config

next-version: 1.0.0
assembly-versioning-scheme: MajorMinorPatch
assembly-versioning-format: '{Major}.{Minor}.{Patch}.{env:BUILD_COUNTER??0}'
assembly-file-versioning-scheme: MajorMinorPatch
continuous-delivery-fallback-tag: ''
mode: ContinuousDeployment
branches:
    release:
        tag: ''        
    develop:
        tag: 'dev'
    master:
        tag: 'master'
ignore:
  sha: []
merge-message-formats: {}

In Team City project I have an environment variable

Name: env.BUILD_COUNTER
Value: %build.counter%

After the build this is what I get
GitVersion.AssemblySemVer = 1.0.0.{env:BUILD_COUNTER??0}

Can you please let me know what I am doing wrong here? Or what do I need to do to make sure env:BUILD_COUNTER gets substituted with the correct value?

Thank you

[jbaehr]

@vishalvatsal The implementation in this PR explicitly requires spaces around the ?? in order to treat it as a fallback-separator. Your config sample seem to omit those spaces.

Note however, that the currently latest GitVersion release features an enhanced implementation, that further allows fallback strings for regular GitVersion variables, too, and also allows for quoted fallback strings containing special characters. cf. #2179

[vishalvatsal]

Thanks a ton @jbaehr.

It works now.