Feature/di3 #2200
Merged
Feature/di3 #2200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added IGitRepoMetadataProvider, IGitVersionContextFactory
asbjornu
approved these changes
Mar 23, 2020
|
🎉 This issue has been resolved in version 5.3.0 🎉 Your GitReleaseManager bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the third (and I guess final) in the series of refactoring adding Dependency Injection
Motivation and Context
There are some classes that needs to keep only the state, not behavior (like GitVersionContext), as well as IRepository should be only one instance to reduce the code accessing the git repository.
Now we are able to inject the IRepository or GitVersionContext in the code where it's needed making the the DI responsible of the creation.
Checklist: