For GitHub Actions, outgoing env vars need to be written to $GITHUV_ENV file #2450
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out #2422 was an incorrect implementation of GitHub Actions' new way of exporting environment variables from a workflow step. GitHub Actions does not parse environment variables out of the log output. It generates a temporary file, which is different for every step of a workflow, that it identifies using the $GITHUB_ENV environment variable. You need to write each key as
{NAME}={VALUE}
to that temp file. GitHub Actions then parses that file and then (I believe) disposes of it before the next step starts.So while #2422 still resulted in a correctly built binary, the exported environment variables essentially disappeared from any later step, making it impossible to do things like deploy prerelease builds to one environment and production builds to a different one.
Description
Related Issue
Motivation and Context
Regression in behavior previously working in GitHub Actions
How Has This Been Tested?
Screenshots (if appropriate):
N/A
Checklist: