Add support for SpaceAutomation #2545
Conversation
|
Thanks. Some tests would be nice. |
|
Not exactly sure what you wanna test here. Do you want to add a sample CI? |
|
There is no pull-request support yet. Honestly, other tests look more like repeating the implementation (or testing |
|
@matkoch, the tests ensure that the build server implementation output the expected stuff. We need tests for that. A sample CI would be fine as well, but does not alleviate the need for tests. |
|
Tests added. Sorry for the long delay! |
|
Awesome, @matkoch! If you could please rebase against |
|
Updated |
| if (setEnvironmentTempFilePath != null && File.Exists(setEnvironmentTempFilePath)) | ||
| { | ||
| File.Delete(setEnvironmentTempFilePath); | ||
| setEnvironmentTempFilePath = null; | ||
| } |
There was a problem hiding this comment.
I think this one is not needed here at all, as only the GH actions build agent is using a file, so it is needed only in the GH tests
| buildServer = sp.GetService<SpaceAutomation>(); | ||
| environment.SetEnvironmentVariable(SpaceAutomation.EnvironmentVariableName, "true"); | ||
|
|
||
| setEnvironmentTempFilePath = Path.GetTempFileName(); |
There was a problem hiding this comment.
I think this one is not needed here at all, as only the GH actions build agent is using a file, so it is needed only in the GH tests
| { | ||
| private IEnvironment environment; | ||
| private SpaceAutomation buildServer; | ||
| private string setEnvironmentTempFilePath; |
There was a problem hiding this comment.
I think this one is not needed here at all, as only the GH actions build agent is using a file, so it is needed only in the GH tests
|
Updated. |
|
Thank you @matkoch for your contribution! |
|
🎉 This issue has been resolved in version 5.6.10 🎉 Your GitReleaseManager bot 📦🚀 |
|
Just a patch increment?:) |
Let me know if anything is missing to support a new CI system.