CA1816: correct idisposable implementation #2780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evangelink
commented
Jul 26, 2021
| @@ -33,8 +33,19 @@ protected RepositoryFixtureBase(IRepository repository) | |||
| /// <summary> | |||
| /// Performs application-defined tasks associated with freeing, releasing, or resetting unmanaged resources. | |||
| /// </summary> | |||
| public virtual void Dispose() | |||
| public void Dispose() | |||
There was a problem hiding this comment.
"Proper" implementation of the disposable pattern.
Note that this change could be considered as breaking change if you consider this class as part of your public API.
Evangelink
commented
Jul 26, 2021
| @@ -13,7 +13,7 @@ public interface IAssemblyInfoFileUpdater : IVersionConverter<AssemblyInfoContex | |||
| { | |||
| } | |||
|
|
|||
| public class AssemblyInfoFileUpdater : IAssemblyInfoFileUpdater | |||
| public sealed class AssemblyInfoFileUpdater : IAssemblyInfoFileUpdater | |||
There was a problem hiding this comment.
When class wasn't inherited I went with the option of sealing the class but we could also go for the disposable pattern implementation.
Note that this change could be considered as breaking change if you consider this was part of your API.
asbjornu
approved these changes
Jul 27, 2021
|
Thank you @Evangelink for your contribution! |
|
🎉 This issue has been resolved in version 5.7.0 🎉 Your GitReleaseManager bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix implementation of the disposable pattern.
Description
See Implementing Dispose and CA1816