Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to usage section and small fixes #2797

Merged
merged 7 commits into from
Aug 6, 2021

Conversation

DarwinJS
Copy link
Contributor

@DarwinJS DarwinJS commented Aug 4, 2021

Description

Describes how a specific example fulfills the requirements of a pipeline level implementation to be referenced in the "usage / Continuous Integration" portion of the documentation.

A direct link to the example was provided to avoid over-coupling to the more detailed ci server instructions in case that information changes to point somewhere else or contain actual code in the future.

Related Issue

Motivation and Context

Ensuring that the GitLab pipeline level solution is easily discoverable in the GitVersion documentation.

How Has This Been Tested?

Yes it is a working example.

Screenshots (if appropriate):

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

docs/input/docs/reference/build-servers/gitlab.md Outdated Show resolved Hide resolved
docs/input/docs/reference/build-servers/gitlab.md Outdated Show resolved Hide resolved
docs/input/docs/reference/build-servers/gitlab.md Outdated Show resolved Hide resolved
docs/input/docs/usage/ci.md Show resolved Hide resolved
docs/input/docs/usage/ci.md Outdated Show resolved Hide resolved
docs/input/docs/reference/build-servers/gitlab.md Outdated Show resolved Hide resolved
@DarwinJS
Copy link
Contributor Author

DarwinJS commented Aug 6, 2021

I'm hoping we are ready to go now? Maybe further language refinements could be done in a future PR.

@asbjornu asbjornu merged commit 02b91fe into GitTools:main Aug 6, 2021
@mergify
Copy link
Contributor

mergify bot commented Aug 6, 2021

Thank you @DarwinJS for your contribution!

@DarwinJS DarwinJS deleted the DarwinJS-add-gitlab-to-usage branch August 7, 2021 15:16
@arturcic arturcic added this to the 5.x milestone Aug 11, 2021
@arturcic arturcic modified the milestones: 5.x, 5.6.12 Aug 14, 2021
@arturcic
Copy link
Member

🎉 This issue has been resolved in version 5.7.0 🎉
The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants