[Docs] Recommend disabling GenerateAssemblyFileVersionAttribute MSBuild prop #2841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. I'm unsure which header this should go under. Suggestions are welcome. 2. I didn't have much time to test them, but I can confirm that adding these to my project resolved certain build errors. Those errors were caused by the build tools generating an AssemblyInfo.g.cs that overwrote or conflicted with GitVersion's generated AssemblyInfo.g.cs.
Co-authored-by: Asbjørn Ulsberg <[email protected]>
5 tasks
asbjornu
approved these changes
Sep 4, 2021
|
Thank you @BinToss for your contribution! |
This was referenced Oct 12, 2021
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By default, DotNet SDK-style projects will generate all assembly info with or without assemblyinfo.cs.
The only
Related Issue
Closes #2840
Motivation and Context
After upgrading a .NET Framework project to build with the DotNet SDK whilst still targetting net4.6.2, I had run into a build error which was easily traced to a conflict with GitVersion's assembly info.
How Has This Been Tested?
Trial and error and hours of scouring MS Docs until I narrowed down the minimal changes needed to resolve the build error.
HaloSPV3/HXE@c3267e0
https://gist.github.com/BinToss/334f5bd8677a7e27fa2e1848d5eb7c53#file-output-log-L2575-L2579
Screenshots (if appropriate):
If NOT
<GenerateAssemblyFileVersionAttribute>false</GenerateAssemblyFileVersionAttribute>Checklist:
@asbjornu