-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linux Arm64 support #2863
Linux Arm64 support #2863
Conversation
only alpine3.12, alpine3.13, alpine3.14, centos.7 do not have an arm64 image
@asbjornu Question. Now that we also have arm64 support we basically have double the images in dockerhub/github packages. I wonder if the current approach of publishing every time we commit to |
Thank you @arturcic for your contribution! |
@arturcic, perhaps we can only publish to the GitHub Package Repository on non-stable builds and to Docker Hub on tagged commits? |
yes makes sense, I will adapt the code |
I just noticed that we seem to be doing the same on NuGet since version 5.2. |
Right, so we keep the same approach then for docker images |
🎉 This issue has been resolved in version 5.8.0 🎉 Your GitReleaseManager bot 📦🚀 |
In this PR I added build infrastructure support for building Arm64 docker images and to test the artifacts with docker images based on Arm64.
Also extended the list of distributions we test with and docker images we build
Here is the list
alpine.3.12, alpine.3.13, alpine.3.14, centos.7, centos.8, debian.9, debian.10, debian.11, fedora.33, ubuntu.18.04, ubuntu.20.04
All of them except Alpine have Arm64 support, alpine in our case is not supported and the LibGit2Sharp.Native does not yet
include support for
linux-musl-arm64
.Also part of the docker images we build I added docker manifests.
For example for debian 11 we have these images:
docker.io/gittools/gitversion:5.7.1-debian.11-5.0-amd64
docker.io/gittools/gitversion:5.7.1-debian.11-5.0-arm64
and a manifest
docker.io/gittools/gitversion:5.7.1-debian.11-5.0
that bundles those 2 toghether.That means you can either pull the docker image by full name and tag:
docker pull docker.io/gittools/gitversion:5.7.1-debian.11-5.0-amd64
or by specifying the platform:
docker pull --platform linux/amd64 docker.io/gittools/gitversion:5.7.1-debian.11-5.0
The exact same images are pushed to GitHub Package Repository
ghcr.io/gittools/gitversion:5.7.1-debian.11-5.0-amd64
ghcr.io/gittools/gitversion:5.7.1-debian.11-5.0-arm64
and a manifest
ghcr.io/gittools/gitversion:5.7.1-debian.11-5.0
https://github.com/GitTools/GitVersion/pkgs/container/gitversion