Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update conventional commits regex to allow "-" in the scope #2922

Merged
merged 3 commits into from
Nov 22, 2021

Conversation

velkovb
Copy link
Contributor

@velkovb velkovb commented Nov 19, 2021

Description

Update conventional commits regex to allow "-" in the scope. It is common to use Jira tickets as scope and they usually have a dash in them.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • [x ] I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Update conventional commits regex to allow "-" in the scope. It is common to use Jira tickets as scope and they usually have a dash in them.
@asbjornu asbjornu added this to the 5.x milestone Nov 22, 2021
@asbjornu asbjornu merged commit e4c37e9 into GitTools:main Nov 22, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 22, 2021

Thank you @velkovb for your contribution!

arturcic pushed a commit that referenced this pull request Nov 22, 2021
Merge pull request #2922 from velkovb/patch-2

Update conventional commits regex to allow "-" in the scope
@arturcic arturcic modified the milestones: 5.x, 5.8.2 Feb 16, 2022
@github-actions
Copy link

🎉 This issue has been resolved in version 5.8.2 🎉
The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants