invalid use of Lazy<GitVersionContext>, #2933 fix doesn't work actualy

[hyabean]

Description

Fixes #2927

Related Issue

#2927

Motivation and Context

Invalid use of Lazy leads the fix of #2933 doesn't work properly. this.versionContext.Value will always be null. This problem was bypassed by way of early access in unit test.
if replace

        bool isCurrentCommitTagged = this.versionContext.IsValueCreated &&
            this.versionContext.Value.IsCurrentCommitTagged;

with
bool isCurrentCommitTagged = context.IsCurrentCommitTagged;,
will cause many other unit tests failed.
So I have to move the if statement into the NormalizeGitDirectory method.

How Has This Been Tested?

Tested the reproduce case in #2927.
all unit tests passed

Screenshots (if appropriate):

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

[hyabean]

@asbjornu #2933 doesn't work because of invalid use of versionContext. So the unit tests passed, but the .exe doesn't work.

[hyabean]

@asbjornu I made a mistake on #2933. So I modify the code again, I'm sure all #2933 is fixed and UT passed. Can you merge this PR?

[asbjornu]

@asbjornu #2933 doesn't work because of invalid use of versionContext. So the unit tests passed, but the .exe doesn't work.

I'm surprised that isn't picked up by any of our tests. Thoughts @arturcic?

[asbjornu]

Could you please rebase this on HEAD of main and resolve conflicts, @hyabean? 🙏🏼

[hyabean]

Could you please rebase this on HEAD of main and resolve conflicts, @hyabean? 🙏🏼

Please go on

[asbjornu]

I'm not comfortable not having tests that exercise the failure you've experienced, but since no existing tests fail, I suppose this should be fine.

[mergify]

Thank you @hyabean for your contribution!

[github-actions]

🎉 This issue has been resolved in version 5.9.0 🎉
The release is available on:

• GitHub Release
• Chocolatey Package
• .Net Global Tool

Your GitReleaseManager bot 📦🚀