Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark dependencies as private assets for GitVersion.MsBuild #3921

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Mark dependencies as private assets for GitVersion.MsBuild #3921

merged 1 commit into from
Feb 20, 2024

Commits on Feb 20, 2024

  1. mark dependencies as private assets for msbuild

    Chnage that all references of the msbuild package are marked as private
    assets, so they don't get added as dependency to the nuget package.
    
    The dependecies field of the nuspec before the change:
    ```xml
    <dependencies>
      <group targetFramework="net6.0">
        <dependency id="System.Text.Json" version="8.0.1" exclude="Build,Analyzers" />
      </group>
      <group targetFramework="net7.0">
        <dependency id="System.Text.Json" version="8.0.1" exclude="Build,Analyzers" />
      </group>
      <group targetFramework="net8.0">
        <dependency id="System.Text.Json" version="8.0.1" exclude="Build,Analyzers" />
      </group>
    </dependencies>
    ```
    
    and afer the change the dependencies of the nuspec look like this:
    ```xml
    <dependencies>
      <group targetFramework="net6.0" />
      <group targetFramework="net7.0" />
      <group targetFramework="net8.0" />
    </dependencies>
    ```
    Louis Seubert committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    b57d60a View commit details
    Browse the repository at this point in the history