Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistency in gix clone with repo url with a dot. #1177

Closed
gl-yziquel opened this issue Dec 12, 2023 · 1 comment · Fixed by #1179
Closed

Inconsistency in gix clone with repo url with a dot. #1177

gl-yziquel opened this issue Dec 12, 2023 · 1 comment · Fixed by #1179
Labels
acknowledged an issue is accepted as shortcoming to be fixed

Comments

@gl-yziquel
Copy link

Current behavior 😯

I have issued the following command:

gix clone https://github.com/cidrblock/drawthe.net

Weirdly enough, the cloned repo on my filesystem is named drawthe and not drawthe.net.

I believe this is an inconsistency that should be fixed. Removing the .git suffix is ok. Removing the .net suffix, not quite so.

Expected behavior 🤔

It should keep the .net suffix.

Git behavior

It keeps the .net suffix.

Steps to reproduce 🕹

gix clone https://github.com/cidrblock/drawthe.net
@Byron Byron added the acknowledged an issue is accepted as shortcoming to be fixed label Dec 12, 2023
@Byron
Copy link
Member

Byron commented Dec 12, 2023 •
edited
Loading

Thanks a lot for letting me know!

A fix will be available with the next release, probably by the end of the year, or today if you build it yourself.

@Byron Byron mentioned this issue Dec 12, 2023
Merged
Byron added a commit that referenced this issue Dec 12, 2023
@Byron
fix: leave extensions in place if they are not .git when using `gix…
0bc9568 
… clone <url>`. (#1177)

Previously it would happily remove e.g. a `.net` extension, even though it's part of the
repository name.

Further, when cloning with `--bare`, don't strip the extension at all as it's common
to keep the `.git` extension in this case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
acknowledged an issue is accepted as shortcoming to be fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gix clone extension handling GitoxideLabs/gitoxide
2 participants
@Byron @gl-yziquel