Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Philips Hue sync with bridge button #2063

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

Pierre-Gilles
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles commented Apr 29, 2024

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Fix #2062

Screenshot 2024-04-29 at 15 48 31
Screenshot 2024-04-29 at 15 48 46

Copy link

cloudflare-workers-and-pages bot commented Apr 29, 2024

Deploying gladys-plus with  Cloudflare Pages  Cloudflare Pages

Latest commit: ceb0209
Status: ✅  Deploy successful!
Preview URL: https://aa5e430b.gladys-plus.pages.dev
Branch Preview URL: https://add-philips-hue-sync-with-br.gladys-plus.pages.dev

View logs

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.39%. Comparing base (e4c0f82) to head (ceb0209).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2063   +/-   ##
=======================================
  Coverage   98.39%   98.39%           
=======================================
  Files         846      847    +1     
  Lines       13802    13820   +18     
=======================================
+ Hits        13580    13598   +18     
  Misses        222      222           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

relativeci bot commented Apr 29, 2024

#2503 Bundle Size — 10.08MiB (+0.04%).

ceb0209(current) vs e4c0f82 master#2480(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#2503
     Baseline
#2480
Regression  Initial JS 5.4MiB(+0.08%) 5.39MiB
No change  Initial CSS 303.21KiB 303.21KiB
Change  Cache Invalidation 53.43% 0%
No change  Chunks 51 51
No change  Assets 170 170
No change  Modules 1465 1465
No change  Duplicate Modules 21 21
No change  Duplicate Code 0.82% 0.82%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2503
     Baseline
#2480
Regression  JS 7.18MiB (+0.06%) 7.17MiB
No change  IMG 2.46MiB 2.46MiB
No change  CSS 319.99KiB 319.99KiB
No change  Fonts 93.55KiB 93.55KiB
No change  Other 17.53KiB 17.53KiB
No change  HTML 13.58KiB 13.58KiB

Bundle analysis reportBranch add-philips-hue-sync-with-bridge...Project dashboard

@Pierre-Gilles Pierre-Gilles merged commit a6569de into master Apr 29, 2024
10 checks passed
@Pierre-Gilles Pierre-Gilles deleted the add-philips-hue-sync-with-bridge-button branch April 29, 2024 14:33
William-De71 pushed a commit to William-De71/Gladys that referenced this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Philips Hue : Implement syncWithBridge function so that newly added lamp can be used in Gladys
1 participant