Limit bigquery records returned #716
Labels
bug
Something isn't working
Comments
tychoish
added a commit
that referenced
this issue
Mar 18, 2024
Closes #716 ---- I found this as I was looking through the issues earlier today. One concern with this (and limit pushdowns in general,) is that we could be _under_ reporting data in these cases: Imagine we only partially push down a predicate but we completly push down the limit. If we get `n` rows back from the data source, but then further filter it down, then we've returned fewer than the target number of rows. Right? This isn't new, and I'm not sure we _shouldn't_ do this because of that, and also I could imagine datafusion passing in different limits than what the user specified. --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Vaibhav Rabber <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Context
Currently limit is ignore during execution. Obviously not great to read everything if a limit is provided.
Expected
Limit is respected.
Actual
Limit ignored.
Impact
The text was updated successfully, but these errors were encountered: