fix: Run delete table jobs after tables are removed from catalog #1437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise the user could end up in a situation where table data was deleted, but the table still exists in the catalog if the request to mutate the catalog failed.
vrongmeal
reviewed
Jul 31, 2023
Comment on lines
+312
to
+313
| # Note that this doesn't guarantee that we drop data in the correct order since | ||
| # we don't have a guarantee on when the background job runs. |
There was a problem hiding this comment.
We can't really guarantee that the data isn't dropped here either. Maybe the background job hasn't still run 🤔
Does this test error on main?
There was a problem hiding this comment.
Yeah this was the easiest test case to write, but definitely not comprehensive.
I was able to get this to fail on main. It was easier to repeat when running locally:
GlareDB (v0.2.1)
Type \help for help.
Using in-memory catalog
〉\open db
Created new session. New database path: db
〉create table drop_data_check as values (1);
create table
〉drop table drop_data_check, table_does_not_exist;
Error: Failed Metastore request: Missing database object; schema: public, name: table_does_not_exist
〉select * from drop_data_check;
Error: Error during planning: Unable to fetch table provider for 'drop_data_check': Failed to create table provider for 'drop_data_check': Not a Delta table: No snapshot or version 0 found, perhaps /Users/sean/Code/github.com/glaredb/glaredb/db/databases/00000000-0000-0000-0000-000000000000/tables/20000/ is an empty dir?
adhish20
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the user could end up in a situation where table data was deleted, but the table still exists in the catalog if the request to mutate the catalog failed.