Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Golang example #1452

Merged
merged 9 commits into from
Aug 1, 2023
Merged

chore: Golang example #1452

merged 9 commits into from
Aug 1, 2023

Conversation

greyscaled
Copy link
Contributor

Progress towards: #1350

@greyscaled
chore: Golang example
fd04de8 
Progress towards: #1350
@greyscaled greyscaled mentioned this pull request Aug 1, 2023
Closed
@greyscaled greyscaled requested a review from scsmithr August 1, 2023 18:39
@greyscaled greyscaled self-assigned this Aug 1, 2023
scsmithr
scsmithr approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@scsmithr scsmithr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Could we change the directory to go instead of Go. The R directory is capitalized to make it more recognizable (since R files end with .R).

@greyscaled
Copy link
Contributor Author

This looks good. Could we change the directory to go instead of Go. The R directory is capitalized to make it more recognizable (since R files end with .R).

for sure

@greyscaled greyscaled enabled auto-merge (squash) August 1, 2023 19:26
@greyscaled greyscaled merged commit f8516bb into main Aug 1, 2023
@greyscaled greyscaled deleted the grey/go-example branch August 1, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scsmithr scsmithr scsmithr approved these changes

Assignees

@greyscaled greyscaled

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@greyscaled @scsmithr