proto serialize logical plans #1528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crates/sqlexec/src/session.rs
Outdated
Comment on lines
239
to
248
| if let DfLogicalPlan::Extension(extension) = &plan { | ||
| match extension.node.name() { | ||
| "CreateTable" => { | ||
| let create_table = extension.node.as_any().downcast_ref::<CreateTable>(); | ||
| return self.create_table(create_table.unwrap().clone()).await; | ||
| } | ||
| _ => {} | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
we want to handle the extensions using our session context, not datafusions, so we need to handle those cases here.
universalmind303
changed the title
scsmithr
reviewed
Aug 10, 2023
scsmithr
approved these changes
Aug 10, 2023
vrongmeal
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this uses the datafusion
Extensionas a means to transmit the custom nodes.In the process, we convert our logicalPlan to datafusion extension nodes.
for example
LogicalPlan(DDL(CreateTable))->DfLogicalPlan(Extension(CreateTable)).