Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove init catalog endpoint for metastore #1604

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

scsmithr
Copy link
Member

Removes needing to "init" a catalog before fetching or mutating it. Since we create catalogs lazily, the only thing "init" was doing was loading it into memory. This change makes it so that that other two endpoints just do that automatically if the catalog isn't found.

These errors should no longer happen:

Missing database catalog: cbdfc895-3d01-4771-92b6-9ab1c43a3bb9

(because I deleted it)

Removes needing to "init" a catalog before fetching or mutating it. Since we
create catalogs lazily, the only thing "init" was doing was loading it into
memory. This change makes it so that that other two endpoints just do that
automatically if the catalog isn't found.

These errors should no longer happen:

```
Missing database catalog: cbdfc895-3d01-4771-92b6-9ab1c43a3bb9
```

(because I deleted it)
@scsmithr scsmithr requested a review from greyscaled August 21, 2023 18:37
@scsmithr scsmithr merged commit 26d4c23 into main Aug 21, 2023
@scsmithr scsmithr deleted the sean/rm-init-metastore branch August 21, 2023 19:02
Copy link
Contributor

@greyscaled greyscaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome ✔️ !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants