feat: implement query \timing command for local repl
#1903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gruuya
requested review from
tychoish,
scsmithr,
universalmind303 and
vrongmeal
gruuya
commented
Oct 11, 2023
Comment on lines
+41
to
+42
| #[clap(long, default_value = "false", hide = true)] | ||
| pub timing: bool, |
There was a problem hiding this comment.
This could also not be hidden, but I didn't feel like it was worth extending the existing cli args just with this.
| @@ -226,6 +233,7 @@ impl LocalSession { | |||
| self.opts.mode, | |||
| self.opts.max_width, | |||
| self.opts.max_rows, | |||
| now, | |||
There was a problem hiding this comment.
This means only ExecutionResult::Query statements will be timed, so for now no DDL/DML timing info.
vrongmeal
reviewed
Oct 11, 2023
Comment on lines
-33
to
-35
| utils.get_customer_ds() | ||
| utils.get_orders_ds() | ||
|
|
There was a problem hiding this comment.
thank you for fixing this!
vrongmeal
approved these changes
Oct 11, 2023
Co-authored-by: Vaibhav Rabber <[email protected]>
tychoish
changed the title
\timing command\timing command for local repl
tychoish
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a \timing command in analogy with the one in psql: