chore(pg proxy): update cloud cert #2272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greyscaled
commented
Dec 15, 2023
greyscaled
commented
Dec 15, 2023
tychoish
approved these changes
Dec 16, 2023
| Dr/IzcLC/pyEmx7spkPfvxebtY64kdFh8qyl9iWZLO9wrpaWY1vV41sjZ1F41AgY | ||
| KaRWGJhHwhyDcYzelsn0Ew2LdB7WfFQZfZe9EHJTj7bd6y6AbkduZ31oebXYlOzo | ||
| 1DkrU2K5aMlVF/vExWpfChk= | ||
| MIIBkzCCAUUCFGipMcv8Oq6O89V+OkbybaF4q3XaMAUGAytlcDBsMQswCQYDVQQG |
There was a problem hiding this comment.
what kind of certificate is this? and where did it come from (I know it's in a test)
Resolves: #2270
greyscaled
force-pushed
the
grey/pg-cert
branch
from
70c88d1 to
aee6b32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes extraneous cert generation for pg proxy. The test was updated to use certs with the ED25519 algorithm. I didn't feel it was important enough to source control cert generation, since there's no need to rotate these in tests. For posterity, I used:
openssl genpkey -out key.pem -algorithm ED25519 openssl x509 -new -key key.pem -subj "/C=US/ST=Texas/L=Austin/O=GlareDB/OU=Engineering/CN=glaredb.com"Resolves: #2270