Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Initial slash command support for psql #894

Merged
merged 4 commits into from
Apr 21, 2023
Merged

Conversation

scsmithr
Copy link
Member

db=> \d
                    List of relations
    Schema     |         Name          | Type  |  Owner  
---------------+-----------------------+-------+---------
 glare_catalog | columns               | table | unknown
 glare_catalog | databases             | table | unknown
 glare_catalog | schemas               | table | unknown
 glare_catalog | session_query_metrics | table | unknown
 glare_catalog | tables                | table | unknown
 glare_catalog | views                 | table | unknown
(6 rows)

db=> \l
                         List of databases
  Name   |  Owner  | Encoding | Collate | Ctype | Access privileges 
---------+---------+----------+---------+-------+-------------------
 default | unknown |          |         |       | 
(1 row)

db=> create external database my_pg from postgres options (connection_string = 'postgres://postgres:postgres@localhost/postgres');
CREATE DATABASE
db=> \l
                         List of databases
  Name   |  Owner  | Encoding | Collate | Ctype | Access privileges 
---------+---------+----------+---------+-------+-------------------
 default | unknown |          |         |       | 
 my_pg   | unknown |          |         |       | 
(2 rows)

Much of this is stubbing things out. This also did add a slightly different pattern for creating scalar funcs, but I think it's easier to look at. I'll switch over our other functions in another pr.

Copy link
Contributor

@greyscaled greyscaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So cool!

@scsmithr scsmithr merged commit d43669c into main Apr 21, 2023
@scsmithr scsmithr deleted the sean/psql-things branch April 21, 2023 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants