Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ColumnTypeUndefinedError in TypeORM #1

Closed
wants to merge 5 commits into from
Closed

fix: ColumnTypeUndefinedError in TypeORM #1

wants to merge 5 commits into from

Conversation

hyunbinseo
Copy link

Reference sveltejs/kit#3334.

Change log

  • Fix errors in tsconfig.json file.
  • Convert hooks.js to hooks.ts.
  • Set types in @PrimaryColumn, @Column

@Glench
Copy link
Owner

Glench commented Jan 30, 2022

I mean, does any of this actually fix this issue? If not, I'm not merging.

@hyunbinseo
Copy link
Author

I mean, does any of this actually fix this issue?

This PR does resolve the 'exception from TypeORM' that you mentioned in sveltejs/kit#3334 and other errors.

Why not clone and check if it works?

@Glench
Copy link
Owner

Glench commented Jan 30, 2022

I see. Thanks! It seems like the only thing that made an appreciable difference here is adding the "type" to the Column constructor. I'll add that it's a little confusing when you add so many irrelevant changes to the pull request. But this feels like a helpful step forward.

This seems like an OK workaround but doesn't actually fix the issue which is that this repository, as it is, should work fine according to the TypeORM docs. But it doesn't.

Also, when you try to npm run build, you get the same error.

@Glench Glench closed this Jan 30, 2022
@Glench Glench reopened this Jan 30, 2022
@hyunbinseo hyunbinseo closed this Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants