Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace builtins input with Click #119

Closed
iromli opened this issue Jun 16, 2020 · 10 comments
Closed

Replace builtins input with Click #119

iromli opened this issue Jun 16, 2020 · 10 comments
Assignees
Labels
enhancement New feature or request Low Priority Priority level low

Comments

@iromli
Copy link
Contributor

iromli commented Jun 16, 2020

The pygluu/kubernetes/prompt consists of lots of input calls. Many of them are dealing with default values, confirmation, validation, etc. Those are tedious tasks and error prone.
I would like to propose to replace them with Click.

@iromli iromli added the enhancement New feature or request label Jun 16, 2020
@moabu moabu added the Low Priority Priority level low label Jun 17, 2020
@moabu
Copy link
Member

moabu commented Jun 17, 2020

We need to think this through a bit. The idea from start was to steer away from external libs and use STD library. But at this point we are likely moving into a container environment installer and this repo will be its source. I think its time for Click to walk in. We also should replace argparse since Click will be available.

@iromli
Copy link
Contributor Author

iromli commented Jun 17, 2020

The idea from start was to steer away from external libs and use STD library

That wouldn't be possible from start as we relies heavily on kubernetes and YAML packages.

@moabu
Copy link
Member

moabu commented Jun 17, 2020

as much as possible. :D Anyways as said lets move on with adding It at this point because we will move into using a Kubernetes manifest to install.

@moabu
Copy link
Member

moabu commented Jun 24, 2020

change of prompts to Click will be replaced gradually .
#125

@moabu
Copy link
Member

moabu commented Jun 25, 2020

#127

@moabu
Copy link
Member

moabu commented Jun 29, 2020

#130

@moabu
Copy link
Member

moabu commented Jun 29, 2020

#131

@moabu
Copy link
Member

moabu commented Jun 30, 2020

#132

@moabu
Copy link
Member

moabu commented Jun 30, 2020

0d6bb38

@iromli
Copy link
Contributor Author

iromli commented Jul 16, 2020

Most of builtins.input have been replaced by click. Closing this issue.

@iromli iromli closed this as completed Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Low Priority Priority level low
Projects
None yet
Development

No branches or pull requests

2 participants