feat: add java memory arguments to services #627
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example error: spec.template.spec.hostAliases.ip: Invalid value: "": must be valid IP address
iromli
reviewed
Mar 8, 2024
| @@ -135,6 +135,8 @@ global: | |||
| oxauth: | |||
| # -- Boolean flag to enable/disable oxauth chart. You should never set this to false. | |||
| enabled: true | |||
| # -- passing custom java options to oxauth. | |||
| gluuCustomJavaOptions: "-XX:MaxDirectMemorySize=2500m -Xmx2200m" | |||
There was a problem hiding this comment.
The number seems based on default resources.limits..
@moabu do we want user to override this setting manually or pre-calculated from its resources.limits. attributes ?
There was a problem hiding this comment.
Pre calculate based on each services resource limits. Otherwise , this will defeat the purpose of the resource limits defined .
moabu
requested changes
Mar 8, 2024
| */}} | ||
| {{- define "fido2.customJavaOptions"}} | ||
| {{ $custom := "" }} | ||
| {{- if .Values.global.fido2.gluuCustomJavaOptions }} |
There was a problem hiding this comment.
This comment applies to all services .
You need to set the Java settings directly in the Java options env pre calculated from the resource limits not through a variable in the values.yaml as that will clash with the resource definitions .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.