-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the Adapter for GoFiber V2 #357
Conversation
The deepsource failed but the detected issue was not introduced by the new code examples/fasthttp/main.go:71:26: call of eng.AddConfig copies lock value: github.com/GoAdminGroup/go-admin/modules/config.Config contains sync.RWMutex examples/gofiber/main.go:76:26: call of eng.AddConfig copies lock value: github.com/GoAdminGroup/go-admin/modules/config.Config contains sync.RWMutex Same error on the other examples :/ |
@chenhg5 Can you help me with this? Can't understand why i have this error but i check all example with go vet fasthttp , echo , all have the same error: So why , the deepsource failed on this PR and not the other example on the master? I know you are busy but it will be great to support this PR. GoFiber is an amazon framework. I'll use go admin with gofiber and it work great 👍 |
@realPy Thanks for your PR and sorry for replying late, cause I am really busy recently. I will pull your code and look into the question. |
@chenhg5 Thanks, I can wait :) i have forked the project until you have time to review. |
@chenhg5 Catch the lock mutex problem. |
Hi @chenhg5 , |
Implement the adapter and unit test for gofiber V2