Added a catch-all for NTSTATUS for error codes we don't care about #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obilodeau
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Clients can return other Error codes that we can safely ignore, such as the MacOS Windows RDP Client when transferring multiple files.
Rather than hardcode 1000s of possible Status codes Just handle the ones we need to and create a catch-all for the ones we don't care about so we don't throw an exception and crash unnecessarily.
Unfortunately I don't have the specific error code I saw on Mac (it was a while ago, and it wasn't every time), but this solution would hopefully also help if other clients do the same thing.