Fix grappling on gridmaps #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lgtm, |
|
I would suggest trying to run everything in physics process and seeing if it runs properly, I'm not a fan of force physics because it takes a costly path especially when physics runs in a separate thread. |
Malcolmnixon
force-pushed
the
grappling-on-gridmaps
branch
from
94215ed to
17f4b95
Compare
Done, and tested as working in the same city map. |
BastiaanOlij
reviewed
Nov 5, 2023
This PR fixes issue GodotVR#541 by only performing RayCast3D tests in the physics update, and by relaxing the type of collider to be of anything the RayCast3D can collide with - including GridMaps.
Malcolmnixon
force-pushed
the
grappling-on-gridmaps
branch
from
17f4b95 to
d4fa428
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #541 by only updating the RayCast3D when needed in the physics frame (to prevent getting stale data), and by relaxing the type of collider to be of anything the RayCast3D can collide with - including GridMaps.
The following screen-shots were taken using the KayKit City Builder Bits assets in a GridMap.
