Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix properties forwarding to only forward customized properties. #647

Merged

Conversation

Malcolmnixon
Copy link
Collaborator

@Malcolmnixon Malcolmnixon commented Jun 20, 2024

This PR fixes bug #646 in property-forwarding for Viewport2Din3D introduced by gdlint cleanup whereby ALL properties of the sub-scene (including its script) were copied to the Viewport2Din3D node.

@Malcolmnixon Malcolmnixon force-pushed the viewport-forward-properties-fix branch from 4eba32b to 9e95e5d Compare June 20, 2024 02:13
Copy link
Member

@BastiaanOlij BastiaanOlij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BastiaanOlij BastiaanOlij added the bug Something isn't working label Jun 20, 2024
@BastiaanOlij BastiaanOlij added this to the 4.3.3 milestone Jun 20, 2024
@Eisenspalter
Copy link

Works now

@Malcolmnixon Malcolmnixon merged commit 8939922 into GodotVR:master Jun 20, 2024
2 checks passed
@Malcolmnixon Malcolmnixon deleted the viewport-forward-properties-fix branch June 20, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants