Fix gdlint errors #691
Open
Fix gdlint errors #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DigitalN8m4r3
approved these changes
Oct 26, 2024
|
thanks! yea I at first I was just gonna fix the start_xr file then figured I'd do the rest while i was there since it's an accessible contribution |
- IMPORTANT: 'arcade_hoops_ctrl.gd' line 96 had a 'tween.kill' that does not call 'tween.kill()' it has been removed to preserve identical functionality while removing a gdlint error. Unknown if this needed to be called but was missing. - Reorder variables - Lessen lines over 100 - Remove trailing whitespace - Prepend "_" to unused function parameters
squidt
force-pushed
the
fix-gdlint-error
branch
from
7c4b7f0 to
c3be759
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most important fix would be to 'start_xr.gd' which reorders the static variable to the top. I've seen at least 2 PRs fail gdlint checks due to this file.