Switch to type:module in package.json

[samthor]

Is your feature request related to a problem? Please describe.
It's hard to test parts of our build system, or have shared logic, since we can't import across different package types.

Describe the solution you'd like
Switch to ESM for the project. We should use "type": "module" in our 'package.json'.

Describe alternatives you've considered

• We could have tests that run both CJS and ESM.
• We could use Rollup's support, but this would only allow CJS => ESM, and not the other way around.

[robdodson]

I'm cool with it if eleventy doesn't barf

[samthor]

There's only.... oh, 394 references to require(). How hard could the fix be?!

[samthor]

It seems like there's a workaround to make this work now but that it's officially unsupported. So maybe this goes on the backburner for a bit.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. To prevent his from happening, leave a comment.

[samthor]

noooo keep open beep bot

…

On Fri, 22 May 2020, 09:29 stale[bot], ***@***.***> wrote: Closed #2582 <#2582>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2582 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAA5DEG2X2BYSVEVDLXOGETRSW2OXANCNFSM4MHNMWLQ> .

[robdodson]

@samthor you can add the accepted label to make the bot ignore stuff.