Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

prefers-color-scheme article for web.dev #1021

Merged
merged 31 commits into from
Jun 27, 2019
Merged

prefers-color-scheme article for web.dev #1021

merged 31 commits into from
Jun 27, 2019

Conversation

tomayac
Copy link
Member

@tomayac tomayac commented Jun 20, 2019 •
edited
Loading

This pull request adds a new:

  • Guide(s) 📘
  • Codelab(s) 🔬

Have you read the wiki on writing a guide or a codelab?

  • Done! 🍰

Does your content tell a user how to fix a Lighthouse audit?
Have you added the Lighthouse audit ID to your YAML?

  • My changes do not mention Lighthouse audits. 🙅‍♂️
  • I have added the Lighthouse audit IDs to my content. 👍

Does your content reference any Glitch projects?
Have you read the wiki on working with Glitch?
Have you added the Glitch project to our team page?

  • My changes do not contain any Glitches. 🙅‍♂️
  • I have read the wiki on working with Glitch. 🍰
  • I have added my Glitches to the team page. 👏

@googlebot googlebot added the cla: yes Contributor has signed the CLA label Jun 20, 2019
@netlify
Copy link

netlify bot commented Jun 20, 2019 •
edited
Loading

Deploy preview for web-dev-staging ready!

Built with commit 733f41d

https://deploy-preview-1021--web-dev-staging.netlify.com

@tomayac tomayac added beta related DO NOT MERGE Actively working on but experimental labels Jun 20, 2019
@tomayac tomayac mentioned this pull request Jun 20, 2019
Closed
8 tasks
@tomayac tomayac self-assigned this Jun 20, 2019
@robdodson

This comment has been minimized.

Sign in to view
@tomayac
Copy link
Member Author

tomayac commented Jun 24, 2019

I'm not sure if the hero image quite makes sense at first glance.

Fair remark. I have just added a new hero image that looks way better.

@chiragd
Copy link

chiragd commented Jun 25, 2019

Non-owner LGTM

@tomayac tomayac requested a review from robdodson June 26, 2019 08:01
robdodson
robdodson approved these changes Jun 26, 2019
View reviewed changes
Copy link
Contributor

@robdodson robdodson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I pointed out a couple of issues and added a clearfix style because I noticed one of the headers was getting a little weird with the floats above it. If you make these changes tomorrow I can merge and deploy.

@tomayac tomayac removed the DO NOT MERGE Actively working on but experimental label Jun 27, 2019
@tomayac tomayac merged commit c84545c into master Jun 27, 2019
@robdodson robdodson deleted the prefers-color-scheme branch June 27, 2019 14:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@emilio emilio emilio left review comments

@rowan-m rowan-m rowan-m left review comments

@robdodson robdodson robdodson approved these changes

@Meggin Meggin Awaiting requested review from Meggin

@mfriesenhahn mfriesenhahn Awaiting requested review from mfriesenhahn

Assignees

@tomayac tomayac

Labels
beta related cla: yes Contributor has signed the CLA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tomayac @robdodson @chiragd @rowan-m @emilio @googlebot