-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Adds guidance about error boundaries to React.lazy docs #924
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Soo good, thank you so much for adding this :)
Literally two of the tiniest nits but otherwise this looks great. Also please add yourself as an author!
authors:
- houssein
- jeffposnick
Co-Authored-By: Houssein Djirdeh <[email protected]>
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
Co-Authored-By: Houssein Djirdeh <[email protected]>
Feedback addressed! I think @robdodson still needs to approve/merge? |
Yep, needs a codeowner approval @robdodson I know we were experimenting with having multiple codeowners before. Will it be easier if I was also a codeowner for the |
Sure thing, I'll put together a PR to add you. |
Fixes #915
Changes proposed in this pull request:
If this PR adds new content please fill out the form below.
If this PR changes existing content you can delete the form.