Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

Adds guidance about error boundaries to React.lazy docs #924

Merged
merged 4 commits into from
May 23, 2019

Conversation

jeffposnick
Copy link
Contributor

Fixes #915

Changes proposed in this pull request:

  • Adds a new section that describes using an error boundary to handle lazy-loading failures.

If this PR adds new content please fill out the form below.
If this PR changes existing content you can delete the form.


Copy link
Contributor

@housseindjirdeh housseindjirdeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Soo good, thank you so much for adding this :)

Literally two of the tiniest nits but otherwise this looks great. Also please add yourself as an author!

authors:
  - houssein
  - jeffposnick

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@jeffposnick
Copy link
Contributor Author

Feedback addressed!

I think @robdodson still needs to approve/merge?

@housseindjirdeh
Copy link
Contributor

Yep, needs a codeowner approval

@robdodson I know we were experimenting with having multiple codeowners before. Will it be easier if I was also a codeowner for the react/ directory?

@robdodson
Copy link
Contributor

@robdodson I know we were experimenting with having multiple codeowners before. Will it be easier if I was also a codeowner for the react/ directory?

Sure thing, I'll put together a PR to add you.

@robdodson robdodson merged commit 77121ce into master May 23, 2019
@robdodson robdodson deleted the react-error-boundary branch May 23, 2019 17:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include <ErrorBoundary> info in React.lazy() docs
4 participants