Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWA Builder CloudAPK (Bubblewrap) zipalign issue "Failed. Status code 500, Error: Internal Server Error, Details: Error generating app package" #552

Closed
bryantvu opened this issue Jun 17, 2021 · 3 comments

Comments

@bryantvu
Copy link

Hello,

I'm trying to get PWA Builder CloudAPK running.
https://github.com/pwa-builder/CloudAPK

I'm getting an error generating an Android package with just the default settings. PWA Builder team did note that I was using the correction SDK version (30.0.3) and suggested that I seek help from the Bubblewrap team instead. Any ideas on what's going on here?
Failed. Status code 500, Error: Internal Server Error, Details: Error generating app package: Error: Command failed: "/home/ubuntu/api/CloudAPK/android-sdk/build-tools/30.0.3/zipalign" -v -f -p 4 /tmp/pwabuilder-cloudapk--24177-thSWAhVabhJC/app/build/outputs/apk/release/app-release-unsigned.apk /tmp/pwabuilder-cloudapk--24177-thSWAhVabhJC/app-release-unsigned-aligned.apk

@andreban
Copy link
Member

andreban commented Jun 17, 2021

Recent versions of the Gradle plugin will automatically zipalign the APK, and calling zipalign in those cases is redundant. See this issue. To reflect this, the Bubblewrap CLI only verifies the APK is zipaligned. ClouldAPK seems to be still calling zipalign here

CC @nohe427 , as he may know more about the zipalign change.

@bryantvu
Copy link
Author

Thanks for getting back so quickly Andre, I've informed the PWAB team of this change.

@JudahGabriel
Copy link
Contributor

FYI, we've updated our side of this as well. I believe you can close this.

nohe427 added a commit that referenced this issue Jan 13, 2022
This changes the user agent that is being sent to sites to match that of
a browser. Some sites were blocking our requests because of the default
user agent. node-fetch has some issues when attempting to set the user
agent, so this was left alone for now, especially because in #552 there
is a mention of potentially removing the user agent.
nohe427 added a commit that referenced this issue Jan 31, 2022
* Set a default user-agent

This changes the user agent that is being sent to sites to match that of
a browser. Some sites were blocking our requests because of the default
user agent. node-fetch has some issues when attempting to set the user
agent, so this was left alone for now, especially because in #552 there
is a mention of potentially removing the user agent.

* Added headers for node-fetch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants