Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ibrahimkarahan I noticed the last checks are failing, and it could be the reason to not release a new version yet, so sending this PR to fix the tests and try to help release a new version soon - a lot of devs from PWABuilder will benefit from this.
Some tests are using
mock-fs
which has some incompatibility at the moment: tschaub/mock-fs#384 and that's the cause for these errors: https://github.com/GoogleChromeLabs/bubblewrap/actions/runs/9993866664/job/27622289533Module mocking with jasmine is a little bit tricky, but very easy with jest, so while doing the replacement of mock-fs to
memfs
I also migrated tojest
(and ts-jest), I know it can be controversial... I couldn't make it work well with jasmine... I did make sure to match the previous expected result, including the customization for some describe errors.Before (from CI):
After: