Add page for CanvasRenderingContext2D.roundRect #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mysteryDate
reviewed
Jul 9, 2021
jpmedley
suggested changes
Aug 11, 2021
content/en-US/api/roundRect.md
Outdated
Comment on lines
76
to
77
| The following example draws 4 rooundRect with `raddi`'s size equals to 1, 2, 3 or 4 and `r` is in | ||
| form of double. |
There was a problem hiding this comment.
Suggested change
| The following example draws 4 rooundRect with `raddi`'s size equals to 1, 2, 3 or 4 and `r` is in | |
| form of double. | |
| The following example draws four `rooundRect` images with `raddi` sizes equal to 1, 2, 3 or 4. `r` is a double. |
There was a problem hiding this comment.
I don't understand the 'r' part. I don't see an 'r' in the example below.
There was a problem hiding this comment.
ctx.roundRect(50, 50, 100, 100, [20]);
means r = 20, radii = [20]
ctx.roundRect(200, 50, 100, 100, [20, 40]);
means r1 = 20 and r2 =40, radii = [20, 40]
I will add some comments to explain this.
|
Thank you for the review! I updated the spec according the comments. |
jpmedley
approved these changes
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a page for CanvasRenderingContext2D.roundRect, the whatwg spec is in progress here: whatwg/html#6765