Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace deprecated protobuf #1348

Closed
wants to merge 1 commit into from
Closed

fix: replace deprecated protobuf #1348

wants to merge 1 commit into from

Conversation

apeabody
Copy link
Collaborator

@apeabody apeabody commented Jan 5, 2023 •
edited
Loading

Fixes #902

go test ./...
?   	github.com/GoogleCloudPlatform/cloud-foundation-toolkit/cli	[no test files]
ok  	github.com/GoogleCloudPlatform/cloud-foundation-toolkit/cli/bpbuild	0.126s
ok  	github.com/GoogleCloudPlatform/cloud-foundation-toolkit/cli/bpcatalog	0.055s
ok  	github.com/GoogleCloudPlatform/cloud-foundation-toolkit/cli/bpmetadata	0.177s
ok  	github.com/GoogleCloudPlatform/cloud-foundation-toolkit/cli/bptest	0.265s
?   	github.com/GoogleCloudPlatform/cloud-foundation-toolkit/cli/report	[no test files]
ok  	github.com/GoogleCloudPlatform/cloud-foundation-toolkit/cli/cmd	0.233s
ok  	github.com/GoogleCloudPlatform/cloud-foundation-toolkit/cli/launchpad	0.218s
ok  	github.com/GoogleCloudPlatform/cloud-foundation-toolkit/cli/scorecard	0.465s
ok  	github.com/GoogleCloudPlatform/cloud-foundation-toolkit/cli/util	0.179s

@apeabody apeabody marked this pull request as draft January 5, 2023 01:32
bharathkkb
bharathkkb approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I also saw #902 but looks like it works now.

@apeabody
Copy link
Collaborator Author

Looks good to me. I also saw #902 but looks like it works now.

@bharathkkb I could also be that I pined them to a specific version rather than latest.

@apeabody
Copy link
Collaborator Author

Drop in favor of a full replacement: #1016

@apeabody apeabody closed this Jan 24, 2023
@apeabody apeabody deleted the ap-patch-46y branch August 7, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

@g-awmalik g-awmalik Awaiting requested review from g-awmalik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update deprecated jsonpb and protobuf/proto dependencies
2 participants
@apeabody @bharathkkb