Improve terraform_docs_awk hack which patches terraform-docs on tf 0.12 #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cray0000
requested review from
aaron-lane,
morgante and
ocsig
as code owners
morgante
approved these changes
Nov 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update terraform_docs_awk hack with a newer version from here:
cloudposse/build-harness#174
Note that the PR I took it from wasn't reviewed yet (thus not merged into master branch yet), but seems to be fixing our issue in
terraform-google-lb-httpjust fine. Also ran it ongenerate_docsof theiammodule and thekubernetes-enginemodule -- and the readme docs generated were the same, so should be safe to merge.