Updates to include a mirror of the ClamAV CVD database #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferrarimarco
requested changes
Nov 16, 2022
There was a problem hiding this comment.
Besides the minor things I spotted (and some are opinions!), I think there's room for two things:
- Setting up Dependabot
- Setting up GitHub Action workflow to build this container image
I can help you with both as I have ready-to-use templates and examples of both.
WDYT?
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
88
to
+105
| app.post('/', async (req, res) => { | ||
| // Sanity check required values. | ||
| if (!req.body || req.body.kind !== 'storage#object') { | ||
| handleErrorResponse(res, 200, `${req.body} is not a GCS Storage Object`); | ||
| return; | ||
| switch (req.body.kind) { | ||
| case 'storage#object': | ||
| await handleGcsObject(req, res); | ||
| break; | ||
| case 'schedule#cvd_update': | ||
| await handleCvdUpdate(req, res); | ||
| break; | ||
| default: | ||
| handleErrorResponse( | ||
| res, | ||
| 200, | ||
| `${JSON.stringify(req.body)} is not supported` + | ||
| '(kind must be storage#object or schedule#cvd_update'); | ||
| break; | ||
| } | ||
| }); |
Check failure
Code scanning / CodeQL
Missing rate limiting
ferrarimarco
approved these changes
Nov 24, 2022
This requires that config.json is used to specify the configuration, that a separate bucket is used to store a mirror of the CVD database and that this bucket is pre-populated before deployment
This requires that config.json is used to specify the configuration, that a separate bucket is used to store a mirror of the CVD database and that this bucket is pre-populated before deployment
This reverts commit 567c479.
This reverts commit 6286f4d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major update to v2.0 to fix #35
This version maintains a ClamAV database mirror to prevent issues with the ClamAV DN