This repository has been archived by the owner on Sep 2, 2022. It is now read-only.
feat:support max concurrent workers for Reconciles #333
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the concurrent workers for Reconciles is 1, user can change the concurrent works by the function
WithOptions
when init the builer.Builder ("sigs.k8s.io/controller-runtime"). But Flink-operator hasn't provide user theWithOptions
funtion to change the concurrent workers. In this Feature, user can change the concurrent workers when deploy the operator, for example,make deploy MAX_CONCURRENT=2
.Feel free to discuss about this feature, In your prod environment, is concurrent worker=1 enough? Did anyone do some performance test about how many QPS is supported when concurrent worker=1? Thanks~.