fix: if execution id support requested for node 12, fail open and dro…

…p execution id support instead of crashing out (#618)
GoogleCloudPlatform · Jul 8, 2024 · 47003fd · 47003fd
1 parent 96ae8aa
commit 47003fd
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/src/options.ts b/src/options.ts
@@ -146,9 +146,13 @@ const ExecutionIdOption = new ConfigurableOption(
       (typeof x === 'boolean' && x) ||
       (typeof x === 'string' && x.toLowerCase() === 'true');
     if (isTrue && !isVersionSatisfied) {
-      throw new OptionsError(
-        `Execution id is only supported with Node.js versions ${requiredNodeJsVersionForLogExecutionID} and above. Your current version is ${nodeVersion}. Please upgrade.`
+      console.warn(
+        `Execution id is only supported with Node.js versions
+        ${requiredNodeJsVersionForLogExecutionID} and above. Your
+        current version is ${nodeVersion}. Please upgrade.`
       );
+      console.warn('Proceeding with execution id support disabled...');
+      return false;
     }
     return isTrue;
   }

diff --git a/test/options.ts b/test/options.ts
@@ -193,14 +193,12 @@ describe('parseOptions', () => {
 
   executionIdTestData.forEach(testCase => {
     it(testCase.name, () => {
+      const options = parseOptions(testCase.cliOpts, testCase.envVars);
       if (
         semver.lt(process.versions.node, requiredNodeJsVersionForLogExecutionID)
       ) {
-        assert.throws(() => {
-          parseOptions(testCase.cliOpts, testCase.envVars);
-        });
+        assert.strictEqual(options.enableExecutionId, false);
       } else {
-        const options = parseOptions(testCase.cliOpts, testCase.envVars);
         assert.strictEqual(options.enableExecutionId, true);
       }
     });