Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding nodeType field in the terraform #10090

Merged
merged 8 commits into from
Apr 2, 2024

Conversation

shailymittal-github
Copy link
Member

@shailymittal-github shailymittal-github commented Feb 29, 2024

Adding nodeType and preciseSizeGb in the Cluster resource in redis.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests). \
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests. \
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.
    google_redis_cluster
redis: added `node_type` and `precise_size_gb` fields to `google_redis_cluster`

@shailymittal-github
Copy link
Member Author

Validated the acceptance test in autopush https://screenshot.googleplex.com/82MqY4DekCpVeLX

@shailymittal-github shailymittal-github marked this pull request as ready for review February 29, 2024 17:32
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from c2thorn February 29, 2024 17:32
@c2thorn
Copy link
Member

c2thorn commented Feb 29, 2024

/gcbrun

1 similar comment
@c2thorn
Copy link
Member

c2thorn commented Mar 4, 2024

/gcbrun

@c2thorn
Copy link
Member

c2thorn commented Mar 6, 2024

/gcbrun

sorry, not sure why build isn't running.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 50 insertions(+))
Terraform Beta: Diff ( 4 files changed, 89 insertions(+), 10 deletions(-))
TF Conversion: Diff ( 1 file changed, 10 insertions(+))
TF OiCS: Diff ( 1 file changed, 1 insertion(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 16
Passed tests: 12
Skipped tests: 0
Affected tests: 4

Click here to see the affected service packages
  • redis

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccRedisCluster_createClusterWithNodeType|TestAccRedisCluster_redisClusterHaExample|TestAccRedisCluster_updateReplicaCount|TestAccRedisCluster_updateShardCount

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccRedisCluster_createClusterWithNodeType[Error message] [Debug log]
TestAccRedisCluster_redisClusterHaExample[Error message] [Debug log]
TestAccRedisCluster_updateReplicaCount[Error message] [Debug log]
TestAccRedisCluster_updateShardCount[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@github-actions github-actions bot requested a review from c2thorn March 21, 2024 09:04
@shailymittal-github
Copy link
Member Author

/gcbrun

2 similar comments
@shailymittal-github
Copy link
Member Author

/gcbrun

@c2thorn
Copy link
Member

c2thorn commented Mar 21, 2024

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 49 insertions(+))
google-beta provider: Diff ( 4 files changed, 88 insertions(+), 10 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 1 insertion(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 16
Passed tests: 12
Skipped tests: 0
Affected tests: 4

Click here to see the affected service packages
  • redis

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccRedisCluster_createClusterWithNodeType|TestAccRedisCluster_redisClusterHaExample|TestAccRedisCluster_updateReplicaCount|TestAccRedisCluster_updateShardCount

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccRedisCluster_createClusterWithNodeType[Error message] [Debug log]
TestAccRedisCluster_redisClusterHaExample[Error message] [Debug log]
TestAccRedisCluster_updateReplicaCount[Error message] [Debug log]
TestAccRedisCluster_updateShardCount[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@c2thorn
Copy link
Member

c2thorn commented Mar 21, 2024

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 49 insertions(+))
google-beta provider: Diff ( 4 files changed, 88 insertions(+), 10 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 1 insertion(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 16
Passed tests: 13
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages
  • redis

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccRedisCluster_createClusterWithNodeType|TestAccRedisCluster_redisClusterHaExample|TestAccRedisCluster_updateShardCount

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccRedisCluster_createClusterWithNodeType[Debug log]
TestAccRedisCluster_redisClusterHaExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccRedisCluster_updateShardCount[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@c2thorn
Copy link
Member

c2thorn commented Mar 21, 2024

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 49 insertions(+))
google-beta provider: Diff ( 4 files changed, 88 insertions(+), 10 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 1 insertion(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 16
Passed tests: 16
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • redis

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

@c2thorn
Copy link
Member

c2thorn commented Mar 22, 2024

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 49 insertions(+))
google-beta provider: Diff ( 4 files changed, 88 insertions(+), 10 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 1 insertion(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 16
Passed tests: 16
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • redis

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

@c2thorn
Copy link
Member

c2thorn commented Apr 1, 2024

/gcbrun

1 similar comment
@shailymittal-github
Copy link
Member Author

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 49 insertions(+))
google-beta provider: Diff ( 4 files changed, 88 insertions(+), 10 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 10 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 1 insertion(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 16
Passed tests: 16
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • redis

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

@c2thorn c2thorn merged commit a9d6aed into GoogleCloudPlatform:main Apr 2, 2024
13 checks passed
rafalmaczewski pushed a commit to rafalmaczewski/magic-modules that referenced this pull request Apr 3, 2024
cmfeng pushed a commit to cmfeng/cmfeng-magic-modules that referenced this pull request Apr 5, 2024
hao-nan-li pushed a commit to hao-nan-li/magic-modules that referenced this pull request Apr 9, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request Apr 19, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request May 8, 2024
pawelJas pushed a commit to pawelJas/magic-modules that referenced this pull request May 16, 2024
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
Cheriit pushed a commit to Cheriit/magic-modules that referenced this pull request Jun 4, 2024
pcostell pushed a commit to pcostell/magic-modules that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants