-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding nodeType field in the terraform #10090
Adding nodeType field in the terraform #10090
Conversation
Validated the acceptance test in autopush https://screenshot.googleplex.com/82MqY4DekCpVeLX |
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
/gcbrun |
1 similar comment
/gcbrun |
/gcbrun sorry, not sure why build isn't running. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 50 insertions(+)) |
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccRedisCluster_createClusterWithNodeType|TestAccRedisCluster_redisClusterHaExample|TestAccRedisCluster_updateReplicaCount|TestAccRedisCluster_updateShardCount |
|
mmv1/third_party/terraform/services/redis/resource_redis_cluster_test.go.erb
Outdated
Show resolved
Hide resolved
/gcbrun |
2 similar comments
/gcbrun |
/gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccRedisCluster_createClusterWithNodeType|TestAccRedisCluster_redisClusterHaExample|TestAccRedisCluster_updateReplicaCount|TestAccRedisCluster_updateShardCount |
|
/gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccRedisCluster_createClusterWithNodeType|TestAccRedisCluster_redisClusterHaExample|TestAccRedisCluster_updateShardCount |
|
/gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: Click here to see the affected service packages
|
… expected to be used
/gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: Click here to see the affected service packages
|
/gcbrun |
1 similar comment
/gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: Click here to see the affected service packages
|
Adding nodeType and preciseSizeGb in the Cluster resource in redis.
If this PR is for Terraform, I acknowledge that I have:
google_redis_cluster